Skip to content

refactor: remove the nullify pkg from the chain testutil#4710

Merged
julienrbrt merged 15 commits intomainfrom
refactor/remove-nullify
May 31, 2025
Merged

refactor: remove the nullify pkg from the chain testutil#4710
julienrbrt merged 15 commits intomainfrom
refactor/remove-nullify

Conversation

@Pantani
Copy link
Collaborator

@Pantani Pantani commented May 30, 2025

No description provided.

@Pantani Pantani self-assigned this May 30, 2025
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:templates component:configs type:services Service-related issues. labels May 30, 2025
@Pantani Pantani changed the title refactor: remove nullify from the chain testutil refactor: remove the nullify pkg from the chain testutil May 30, 2025
@Pantani Pantani marked this pull request as ready for review May 30, 2025 02:05
@Pantani Pantani enabled auto-merge (squash) May 30, 2025 02:05
julienrbrt
julienrbrt requested changes May 30, 2025
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep the NonIndex or fill in ValueIndex (but it doesnt make sense for all times)

e.g: ignite s module bar --params baz:bytes (we should add a passing/failing test case for this btw)

@github-actions github-actions bot removed the type:services Service-related issues. label May 31, 2025
@Pantani Pantani requested a review from julienrbrt May 31, 2025 01:55
@Pantani
Copy link
Collaborator Author

Pantani commented May 31, 2025

Can we backport this to version 29?

julienrbrt
julienrbrt previously approved these changes May 31, 2025
View reviewed changes
@julienrbrt julienrbrt disabled auto-merge May 31, 2025 06:33
@julienrbrt julienrbrt self-assigned this May 31, 2025
@Pantani
Copy link
Collaborator Author

Pantani commented May 31, 2025

The ValueLoop, ToString, and ToBytes methods should be implemented for both indexed and non-indexed values. We need to revert this one for the PR works again: 96939bd

@julienrbrt
Revert "continue revert"
b4c551c 
This reverts commit 96939bd.
@julienrbrt
Copy link
Member

julienrbrt commented May 31, 2025

The ValueLoop, ToString, and ToBytes methods should be implemented for both indexed and non-indexed values. We need to revert this one for the PR works again: 96939bd

just seen that yes :D

@julienrbrt julienrbrt removed their assignment May 31, 2025
julienrbrt
julienrbrt previously approved these changes May 31, 2025
View reviewed changes
@julienrbrt julienrbrt mentioned this pull request May 31, 2025
Merged
@github-actions github-actions bot added component:docs Documentation additions or improvements. component:packages labels May 31, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit e25ae4c):

https://igntservices-docs--pr4710-refactor-remove-null-7vn0te4f.web.app

(expires Sat, 07 Jun 2025 07:09:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5

julienrbrt
julienrbrt previously approved these changes May 31, 2025
View reviewed changes
julienrbrt
julienrbrt previously approved these changes May 31, 2025
View reviewed changes
@julienrbrt julienrbrt enabled auto-merge (squash) May 31, 2025 07:02
@Pantani
Copy link
Collaborator Author

Pantani commented May 31, 2025

The ValueLoop, ToString, and ToBytes methods should be implemented for both indexed and non-indexed values. We need to revert this one for the PR works again: 96939bd

sorry, only the valueLoop

@julienrbrt julienrbrt merged commit 8fd169c into main May 31, 2025
45 checks passed
@julienrbrt julienrbrt deleted the refactor/remove-nullify branch May 31, 2025 07:31
@BrewTestBot BrewTestBot mentioned this pull request May 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz

@toschdev toschdev Awaiting requested review from toschdev

Assignees

@Pantani Pantani

Labels

component:ci CI/CD workflow and automated jobs. component:configs component:docs Documentation additions or improvements. component:packages component:templates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pantani @julienrbrt